Get validators from delegation, including jailed#1017
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Cosmos staking functionality by ensuring that all validators a user has delegated to, including those that are currently inactive or jailed, are correctly retrieved and displayed. Previously, only bonded validators were queried, leading to incomplete information for users whose delegated validators became unbonded. The changes introduce a new RPC method to fetch delegator-specific validators and integrate it into the staking data retrieval process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where delegations to inactive or jailed validators were not being displayed. It achieves this by fetching validators based on the user's delegations, rather than fetching all bonded validators. The approach is sound. However, I've noted a potential issue with pagination in the new API call which could affect users with a large number of delegations.
can you make sure it has a name? |
This is an issue on ios side, will push a fix there too |
0xh3rman
changed the title
2 participants
self.get_validators()only query bonded validators, if user delegated to a validator and it becomes inactive, the delegation will be gone